Dynamic navigation link target #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for developer-center ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sisou
reviewed
Oct 1, 2024
| @@ -9,6 +9,10 @@ import ThemeSwitcher from './ThemeSwitcher.vue' | |||
| defineProps<{ navigation: NavigationType }>() | |||
|
|
|||
| const currentTrigger = ref('') | |||
|
|
|||
| function getTarget(url: string) { | |||
| return url.startsWith('http') ? '_blank' : '' | |||
There was a problem hiding this comment.
When you return undefined as the else case, does it leave out the target attribute then in the rendered HTML?
sisou
requested changes
Oct 1, 2024
onmax
force-pushed
the
onmax/heading-targe
branch
from
1140994
to
6791799
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.