Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: add missing At context rules #133

Merged
merged 1 commit into from
Mar 22, 2025
Merged

Conversation

zerbina
Copy link
Collaborator

@zerbina zerbina commented Mar 21, 2025

Summary

Also allow evaluation/reduction of the index operand of an At
expression when the array operand is not an lvalue expression.

Details

  • add an As pattern to both E and F that admits all val in the
    array operand position
  • add two tests, one covering the (As val le) case and one the
    (As val e) case

Notes For Reviewers

Also allow evaluation/reduction of the index operand of an `At`
expression when the array operand is not an lvalue expression.

* add an `As` pattern to both `E` and `L` that admits alls `val` in the
  array operand position
* add two tests, one covering the `(As val le)` case and one the
  `(As val e)` case
@zerbina zerbina added the bug Something isn't working label Mar 21, 2025
@zerbina zerbina requested a review from saem March 21, 2025 22:48
@saem saem merged commit 125a3cf into nim-works:main Mar 22, 2025
6 checks passed
@zerbina zerbina deleted the spec-fix-at branch March 22, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants