phy: use structured output formatting #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of rendering the result value to a string, render it to an S-expression (`SexpNode`), making it easier to work with for follow-up processing. The S-expressions representation is meant to mirror how the values are represented in the language specification.
Meant to be used for the `phy` output.
Both the type and value are shown in their S-expression representation. This'll make output comparison for the new source language test approach easier.
Both the program output and `phy` output (i.e., the result value + type) were written to the output stream without any separator. To be able to compare both against an expected string, when running `phy` in runner mode, their now separate by the `"!BREAK!"` string, which the tester understands.
The tester supports the runner supplying multiple output fragments, but their expected content could previously not be provided through just the test specification. With the new positional output specification, this is now possible.
saem
approved these changes
Mar 4, 2025
Co-authored-by: Saem Ghani <[email protected]>
Small QoL improvement.
zerbina
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
process)
output.0: ...) in testspecification
phyoutput when in runner modeDetails
type) from
vmexec.run. It matches how the value would be representedin the source language definition
to the output and error stream) from the value + type, so that both
count as separate fragments for the tester and can be compared
independently
possible to provide the expected string for leading fragments
directly, without the need to use
.expectedfilesexprtests'outputspecificationsThe output is now much easier to parse programmatically.
Notes For Reviewers