fixes #25008; Compiler internal error with static overload #25234
+21
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th static overload
Araq
reviewed
Oct 28, 2025
| discard | ||
| of nkSym: | ||
| if n.sym.kind in {skVar, skLet} and sfGlobal notin n.sym.flags: | ||
| n.sym.position = 0 |
There was a problem hiding this comment.
What is position even used for? By the VM?
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
narimiran
pushed a commit
that referenced
this pull request
Oct 28, 2025
fixes #25008 It seems that `semOverloadedCall` evaluates the same node twice using `tryConstExpr` in order for `efExplain` to print all the diagnostic output. The problem is that `tryConstExpr` has side effects, i.e., it changes the slot index of variables after VM execution. (cherry picked from commit 130eac2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #25008
It seems that
semOverloadedCallevaluates the same node twice usingtryConstExprin order forefExplainto print all the diagnostic output. The problem is thattryConstExprhas side effects, i.e., it changes the slot index of variables after VM execution.