Throw error when parsing invalid section0 indicator #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @measuredweighed! I will tag a new version right away. |
|
v1.2.4 is out now |
|
👍 Thank you for such a quick response (and for all of your hard work on the wonderful library). |
|
I had to update a test as well, so the correct version is now v1.2.5. Glad you liked the library 😄 What are you using it for if I can ask? If you dont want to answer publicly my email is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue mentioned in #17 whereby invalid/arbitrary data would cause a panic. This change basically requires that section0's GRIB indicator be valid before allowing parsing to continue, throwing an error instead of panic-ing.
I've attached an example file from a NOAA.gov source that returned an HTML error page instead of the expected grib file, which caused the panic for us.