Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1 #8

Draft
wants to merge 72 commits into
base: master
Choose a base branch
from
Draft

V1 #8

wants to merge 72 commits into from

Conversation

kitallis
Copy link
Contributor

@kitallis kitallis commented May 31, 2020 •
edited
Loading

This PR should be merged to master once we're happy with the alpha-mvp.

prabhanshuguptagit and others added 30 commits April 10, 2020 23:20
@prabhanshuguptagit
Fix path drawing mechanism
926be70
@prabhanshuguptagit
Merge branch 'master' of https://github.com/nilenso/pencil.space into…
2351f68 
… cljs
@kitallis
Merge branch 'master' into cljs
0fd05f3
@kitallis
Get a basic re-frame system functioning
ab8766c
@kitallis
Add some sine-wave as one types their nick
88c5cea
@kitallis
Stick a base64 avatar of the generated canvas painting
988ad8b
@kitallis
Clear the avatar if nick is removed
5d16e5b
@kitallis
Stick the canvas page into draw ns
3bde7ab
@kitallis
work-in-progress attempt at converting draw ns to reagent component
7a3fc19
@kitallis
Add a tube ns to talk to phoenix over channels
61b1d29
@kitallis
Basic broadcasting now works!
e475d35
@kitallis
work-in-progress attempt at converting draw ns to reagent component
2093c76
@prabhanshuguptagit
Fix path drawing
e46ba7b
@prabhanshuguptagit
Refactor draw cljs
e9fcaaa
@kitallis
add a small chat system
17b7e02
@kitallis
Draw is now tube ready
2dd64f7
@kitallis
Merge branch 'chat' into cljs
c502ec0
@kitallis
Destructure the draw data properly
3c819c9
@kitallis
Add avatar, nick and time to chat messages
34ffd6b
@prabhanshuguptagit
Fix drawing over websockets
f9256b8
@prabhanshuguptagit
Refactor
2823761
@prabhanshuguptagit
Remove refactored files left behind
4f2ee10
@prabhanshuguptagit
Add chatbox to drawing page, hack some responsiveness into the page
24de284
@prabhanshuguptagit
Remove component-did-update
7a75f63
@prabhanshuguptagit
Make drawing chatbox functional
5db65c9
@prabhanshuguptagit
Set max width on drawing board
e7aa3c8
@prabhanshuguptagit
Refactor chat mount
39bf6f4
@kitallis
Merge branch 'master' into cljs
3a10e09
@prabhanshuguptagit
Some CSS hackery for mobile
0fefc7d
@prabhanshuguptagit
Remove hash at end of URL
2db64ee
kitallis and others added 12 commits May 30, 2020 16:07
@kitallis
Better controller-layer error handling
f8ef6f4
@kitallis
Just pull the room name from join params instead of socket
37098ec
@kitallis
First attempt at connecting the cljs app with elixir hosted server
5241307
@prabhanshuguptagit
Remove cljs compile files
3f1d075
@prabhanshuguptagit
Refactor chat
68d41e3
@prabhanshuguptagit
Move components into directories
03d19a4
@kitallis
Push assets
7324b57
@yudistrange
Fix: Phoenix routes to serve static assets
436dcb3 
- Change the port on API.cljs
- Recompile the assets
@prabhanshuguptagit
Make reframe10x work
107f6b9
@prabhanshuguptagit
Untrack cljs compile files
cbadb7d
@prabhanshuguptagit
Chat refactor draft
7d3f977
@kitallis
Add game state (#7)
1b785b3 
* Rename RoomChannel to GameChannel and make it room sensitive
* Refactor exists? -> presence
* Add basic host game state
* Pull out high-level coordination stuff in a stateless Game module
* Add functions to update host & participants on Game
* Hook up game state updates with controller
* Make game channel check for presence of game
* Refactor Game-related modules
* Better controller-layer error handling
* Just pull the room name from join params instead of socket
* Specify imported functions from ControllerHelpers
@kitallis kitallis added this to the alpha milestone May 31, 2020
@kitallis kitallis changed the title Alpha Release Release V1 May 31, 2020
@kitallis kitallis changed the title Release V1 V1 May 31, 2020
@nid90
Copy link

nid90 commented Jun 1, 2020

Why is this a single PR?

@kitallis
Copy link
Contributor Author

kitallis commented Jun 1, 2020

Why is this a single PR?

Because I want to avoid the trouble of creating PRs for daily updates until we reach alpha.

The alpha branch is basically our trunk or master at the moment. Until alpha is merged to master, we're going to directly commit everything to this branch, it'll allow us to catch regressions faster etc. since we don't have any tests at the moment. Once we move to master, we're going to start making reviewable PRs. Just doing this for speed to not get blocked on reviews etc.

I'll only make separate PRs for significant Elixir/Phoenix changes.

kitallis and others added 7 commits June 8, 2020 01:06
@kitallis
Make the APIs idempotent and have the same payload (host/participant)
8510d06
@kitallis
Lobby (#10)
c936a6e 
* Get 1st draft of lobby

* Break out subs, events and fx into separate namespaces

* launch multiple subscriptions from tube.fx

* Get the lobby functional
@kitallis
Remove dead (prn)s
d93e2e1
@kitallis
Hook up the flow to drawing page (game/view)
cb12a30
@kitallis
Minor refactor
45cc59a
@yudistrange
Add CI via github actions (#11)
8e7fb22 
* Add CI via github actions
* Add a compilation step
* Add postgres service to run tests in github workflow
* Add configuration for running tests on the CI
* Fix: The postgres_host configuration while running the tests in CI
* Fix: Incorrect assertions in the error view tests
* Add CI status badge
@dependabot
Bump elliptic from 6.5.2 to 6.5.3 in /client/cljs (#14)
2934d83 
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](indutny/elliptic@v6.5.2...v6.5.3)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
alpha
Development

Successfully merging this pull request may close these issues.
4 participants
@kitallis @nid90 @prabhanshuguptagit @yudistrange