Add support for explain #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govindkrjoshi
force-pushed
the
add-support-for-explain
branch
2 times, most recently
from
8722e61
to
13794b4
Compare
govindkrjoshi
force-pushed
the
add-support-for-explain
branch
from
13794b4
to
287519b
Compare
kitallis
reviewed
Aug 20, 2021
There was a problem hiding this comment.
@govindkrjoshi Looks mostly good; added a small comment. Could you add a runnable README example; ref?
src/honeysql_postgres/format.cljc
Outdated
| (defmethod format-clause :explain [[_ [params]] _] | ||
| (if (empty? params) | ||
| "EXPLAIN" | ||
| (let [params-string-map |
There was a problem hiding this comment.
@govindkrjoshi Shall we consider moving these static maps out to avoid creating them every time the format on explain is called?
kitallis
approved these changes
Aug 20, 2021
| (sql/format)) | ||
| => ["EXPLAIN (FORMAT JSON) SELECT * FROM PRODUCTS"] | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Can we kill these 2 extra lines? 2 lines should be enough.
| @@ -240,6 +240,31 @@ The `ilike` and `not-ilike` operators can be used to query data using a pattern | |||
| 0.25 0.50 0.75] | |||
| ``` | |||
|
|
|||
| ### explain | |||
There was a problem hiding this comment.
We can add this section to the index upstairs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue: #68