Implement Sessions #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is exciting! 🥳 |
niklaslong
force-pushed
the
12-sessions
branch
from
3898769 to
8283256
Compare
niklaslong
force-pushed
the
12-sessions
branch
from
bd70297 to
9eeb920
Compare
|
@fancycade This should be god to go. I've opened #24 and #25 and #26 based on things that I noticed when implementing this. |
fancycade
approved these changes
Sep 16, 2020
There was a problem hiding this comment.
Looks good! This was quite the effort!
The c code is similar to how accounts was done so I think it is okay.
Didn't notice any misspellings.
Re #24 >
I think returning tuples makes sense. If there is a chance to error then I think tuple is good, otherwise you can return the value because there is no way it could be anything else.
My suggestion would be to do a quick release, then try to integrate it with the SDK and see how you feel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12.