Update to 2021 edition #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Sorry for leaving this hanging. I now added some justification for the maintenance status: https://github.com/niklasf/rust-huffman-compress#Alternatives. If you like, you can override crates.io with your fork (which looks good). Sent an invite that should allow you to do that. Ofc you can also use your own crate name, or not publish at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey niklasf, searched an huffman lib and found this one which coincidentally is written by you 😅 Updated the code to 2021 edition and fixed clippy lints (as well as updating to criterion).
Would probably want to switch frombit_vectobitvecwhich the ecosystem has more largely adopted.Given the maintenance status feel free not to review at all I'll use a fork in the meantime (or at all). Cheers