Skip to content

Fix encoding in forms #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
quique0194 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix encoding in forms #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d868d6d
Fix encoding
quique0194 Oct 18, 2016
cbc5a26
Make ServerConnection._writeline accept unicode strings too
quique0194 Dec 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions webkit_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,9 +513,12 @@ def issue_command(self, cmd, *args):
self._writeline(cmd)
self._writeline(str(len(args)))
for arg in args:
arg = str(arg)
if type(arg) != str and type(arg) != unicode:
Copy link
Author

@quique0194 quique0194 Dec 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function cannot handle unicode strings. Try the following:

str(u"canción")

arg = str(arg)
if type(arg) == unicode:
Copy link
Author

@quique0194 quique0194 Dec 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only unicode strings need to be encoded as utf-8 to be sent as bytes to webkit server

arg = arg.encode("utf-8")
self._writeline(str(len(arg)))
self._sock.sendall(arg.encode("utf-8"))
self._sock.sendall(arg)

return self._read_response()

Expand All @@ -537,5 +540,7 @@ def _read_message(self):
return self.buf.read(size).decode("utf-8")

Copy link
Author

@quique0194 quique0194 Dec 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a problem if you encode twice. Try the following:

u"canción".encode('utf-8').encode('utf-8')

Copy link
Author

@quique0194 quique0194 Dec 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Encoding twice can create errors:

u"canción".encode('utf-8').encode('utf-8')

def _writeline(self, line):
if type(line) == unicode:
line = line.encode("utf-8")
""" Writes a line to the underlying socket. """
self._sock.sendall(line.encode("utf-8") + b"\n")
self._sock.sendall(line + b"\n")