Allow specifying relative DFS index for focus command #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing + or - prefix. Ref: nikitabobko#248
|
Thanks for the idea, but I think it should be implemented as separate You also forgot to update the docs and shell completion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also wanted dfs next/prev as discussed in #248.
I figured I could implement without adding additional flags or breaking backwards compatibility by having the parser look for an optional +/- suffix on the existing dfs-index argument. The next/previous behavior can be had via:
focus --dfs-index +1
focus --dfs-index -1
respectively.
As with my other PR, I haven't implemented any automated tests around this but would be happy to look into doing so if desired.