Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Title property to MultiUrlPicker for link title retrieval #347

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

humandigital-michiel
Copy link
Contributor

@humandigital-michiel humandigital-michiel commented Feb 12, 2025

To get the title of the link in graphql

image

@nikcio
Copy link
Owner

nikcio commented Feb 12, 2025

Hi @humandigital-michiel,

This looks like a fine addition. Can you update the PR with the correct snapshot files (From the integration tests):

  1. Find the folder: src\Nikcio.UHeadless.IntegrationTests\Snapshots
  2. Delete the folder
  3. Then run dotnet test inside src\Nikcio.UHeadless.IntegrationTests
    a. This will regenerate the snapshots with the correct content.
    b. Note the first run will make all tests fail as the snapshot it's checking against is missing this is expected. If you want to make sure everything is as it should be you can just run dotnet test a second time.

# Conflicts:
#	src/Nikcio.UHeadless.IntegrationTests.TestProject/umbraco/Data/Default-Tests.sqlite
@nikcio nikcio merged commit 8faf493 into nikcio:contrib Feb 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants