Updated ejs dependency and fixed #1518 - a problem with reading capab…

…ilities incorrectly
nightwatchjs · Dec 5, 2017 · c3418c5 · c3418c5
1 parent 4aa6aa2
commit c3418c5
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 13 deletions.
diff --git a/lib/runner/clientmanager.js b/lib/runner/clientmanager.js
@@ -26,8 +26,10 @@ ClientManager.prototype.init = function(opts) {
   this['@client'].once('selenium:session_create', function() {
     var capabilities = this.api.capabilities || {};
     var browserName = (capabilities.browserName && capabilities.browserName.toUpperCase()) || '';
+    var browserVersion = this.api.capabilities.version || this.api.capabilities.browserVersion;
+    var platformVersion = this.api.capabilities.platform || this.api.capabilities.platformVersion;
 
-    self.options.report_prefix = browserName + '_' + this.api.capabilities.version + '_' + this.api.capabilities.platform + '_';
+    self.options.report_prefix = browserName + '_' + browserVersion + '_' + platformVersion + '_';
   });
   return this;
 };

diff --git a/lib/runner/reporters/junit.js b/lib/runner/reporters/junit.js
@@ -66,12 +66,10 @@ module.exports = new (function() {
     var filename = path.join(output_folder, opts.filename_prefix + moduleName + '.xml');
 
     var rendered = ejs.render(data, {
-      locals: {
-        module     : module,
-        moduleName : moduleName,
-        className  : className,
-        systemerr  : globalResults.errmessages.join('\n')
-      }
+      module: module,
+      moduleName: moduleName,
+      className: className,
+      systemerr: globalResults.errmessages.join('\n')
     });
 
     fs.writeFile(filename, rendered, function(err) {

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "nightwatch",
-  "description": "A node.js bindings implementation for selenium 2.0/webdriver",
+  "description": "Easy to use Node.js based End-to-End testing solution for browser based apps and websites, using the W3C WebDriver API.",
   "version": "0.9.17",
   "author": {
     "name": "Andrei Rusu",
@@ -16,7 +16,7 @@
   },
   "dependencies": {
     "chai-nightwatch": "~0.1.x",
-    "ejs": "0.8.3",
+    "ejs": "2.5.7",
     "lodash.clone": "3.0.3",
     "lodash.defaultsdeep": "4.3.2",
     "minimatch": "3.0.3",

diff --git a/test/lib/mocks.json b/test/lib/mocks.json
@@ -4,7 +4,7 @@
     {
       "url" : "/wd/hub/session",
       "postdata" : "{\"desiredCapabilities\":{\"browserName\":\"firefox\",\"javascriptEnabled\":true,\"acceptSslCerts\":true,\"platform\":\"ANY\"}}",
-      "response" : "{\"status\": 0, \"sessionId\": \"1352110219202\", \"value\": { \"javascriptEnabled\": true, \"browserName\": \"firefox\", \"version\": \"TEST\", \"platform\": \"TEST\"}, \"state\": null}",
+      "response" : "{\"status\": 0, \"sessionId\": \"1352110219202\", \"value\": { \"javascriptEnabled\": true, \"browserName\": \"firefox\", \"browserVersion\": \"TEST\", \"platformVersion\": \"TEST\"}, \"state\": null}",
       "responseHeaders" : {
       },
       "statusCode" : 201,

diff --git a/test/src/core/testNightwatchApi.js b/test/src/core/testNightwatchApi.js
@@ -18,8 +18,8 @@ module.exports = MochaTest.add('test Nightwatch Api', {
     assert.deepEqual(api.capabilities, {
       javascriptEnabled: true,
       browserName: 'firefox',
-      version: 'TEST',
-      platform: 'TEST'
+      browserVersion: 'TEST',
+      platformVersion: 'TEST'
     });
 
     assert.deepEqual(api.globals, {

diff --git a/test/src/runner/testRunner.js b/test/src/runner/testRunner.js
@@ -202,7 +202,7 @@ module.exports = {
           }
           var content = data.toString();
           try {
-            assert.ok(content.indexOf('<failure message="AssertionError: 1 == 0 - expected &quot;0&quot; but got: &quot;1&quot;">') > 0, 'Report contains failure information.')
+            assert.ok(content.indexOf('<failure message="AssertionError: 1 == 0 - expected &#34;0&#34; but got: &#34;1&#34;">') > 0, 'Report contains failure information.')
             done();
           } catch (err) {
             done(err);