Skip to content

Commit

Permalink
Fix iOS standalone issue and remove unnecessary logs in Android setup. (
Browse files Browse the repository at this point in the history
  • Loading branch information
itsspriyansh authored Jun 3, 2024
1 parent ebfb259 commit fea7bad
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
11 changes: 8 additions & 3 deletions src/commands/android/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export class AndroidSetup {

this.postSetupInstructions(result, setupConfigs);

if (setupConfigs.mode !== 'emulator') {
if (!this.options.standalone && setupConfigs.mode !== 'emulator') {
Logger.log(`${colors.bold('Note:')} Please make sure you have required browsers installed on your real-device before running tests.\n`);
}

Expand Down Expand Up @@ -995,7 +995,9 @@ export class AndroidSetup {
if (result) {
Logger.log(`${colors.green('Great!')} All the requirements are being met.`);

if (setupConfigs.mode === 'real') {
if (this.options.standalone) {
// Logs related to standalone mode to be added here.
} else if (setupConfigs.mode === 'real') {
Logger.log('You can go ahead and run your tests now on your Android device.\n');
} else {
Logger.log('You can go ahead and run your tests now on an Android device/emulator.\n');
Expand All @@ -1006,7 +1008,10 @@ export class AndroidSetup {
} else {
if (result) {
Logger.log(`${colors.green('Success!')} All requirements are set.`);
if (setupConfigs.mode === 'real') {

if (this.options.standalone) {
// Logs related to standalone mode to be added here.
} else if (setupConfigs.mode === 'real') {
Logger.log('You can go ahead and run your tests now on your Android device.\n');
} else {
Logger.log('You can go ahead and run your tests now on an Android device/emulator.\n');
Expand Down
4 changes: 4 additions & 0 deletions src/commands/ios/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,9 @@ export const AVAILABLE_OPTIONS: AvailableOptions = {
appium: {
alias: [],
description: 'Make sure the final setup works with Appium out-of-the-box.'
},
standalone: {
alias: [],
description: 'Do standalone setup (no Nightwatch-related requirements will be downloaded).'
}
};

0 comments on commit fea7bad

Please sign in to comment.