-
Notifications
You must be signed in to change notification settings - Fork 71.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev next release 15.0.3 #8145
base: master
Are you sure you want to change the base?
dev next release 15.0.3 #8145
Conversation
Update 10/16/19
Update README.md
14.2.1 update
…It displays "Internet offline." until internet is restored. This fix addresses the issue that with a lost internet connection, clock view continues to display a stale CGM values forever, with no clue that internet connectivity is lost. This fix shows "Internet offline." for the duration that is it lost, then returns to normal when internet is restored.
Add "virtAsstLaunch"
Changing default SAGE warn and urgent threshold defaults to be useful for 10 day sensors rather than 7 day sensors from the G5 era. SAGE pill turns yellow at day 9 and red 4 hours before expiration of 10 days. Once G6 is retired, consider setting WARN to 10 days and URGENT to 10.5 days.
There are three high priority candidates for release:
There are some other PRs as well, help evaluating these as well as prepping the release and potential release notes are welcome. |
Updated to stop Nightscout crashing if APNs response is not received well from Apple.
… wip/bewest/nspro-apns-crashfix
…e' into wip/bewest/collaborations Nice work, thanks for your contributions.
…ollaborations Gracias!
…est/collaborations
Let's chat about what's needed to push forward with dev @bewest 👍 |
This reverts commit cec3eeb. Need to update tests? Not immediately clear why tests updated from 6 days to 9 days fails, so revertinig for now.
Wip/bewest/collaborations
@AndyLow91, sure thing. Please schedule some time with me on calendar, or find me on slack or discord so we can chat and coordinate properly. |
@AndyLow91 I tried adding you to the reviewers list and it turns out I don't have admin access. 🤷 |
This fixes the issue of a "stale" CGM value displaying indefinately.
@AndyLow91, I think you should have received an invite to join a github team. Both areas contain discussions around the major areas that need development. For this particular release, I was hoping to get some testing with AAPS on the mongo updates. It seems increasingly unlikely that any delay of this as a hotfix release will produce any useful information on the mongo testing. Is there any reason not to treat this as a hotfix and get it out by end of week? The same question for mongo patches applies to nightscout-connect: is it better to scuttle potential release there for next release? |
Switching the way units is fetched to this way makes it similar to the other code already in place that does something similar. This allows the tests to pass with the existing fixtures. Considering augmenting additional tests that explicitly tests whether the relevant branch of code is taken.
This adds the latest long term support version of node to the automated testing matrix.
Wip/bewest/collaborations
Add notes about the Google Assistant integration being broken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All commits reviewed and I'm happy. It all makes sense. thanks
Please submit pull requests for next release here.