-
Notifications
You must be signed in to change notification settings - Fork 113
BSLagBoneController support #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TackYs
wants to merge
3
commits into
niftools:develop
Choose a base branch
from
TackYs:BSLagBoneController_support
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,7 +40,7 @@ | |
| from io_scene_niftools.modules.nif_export import types | ||
| from io_scene_niftools.modules.nif_export.animation.transform import TransformAnimation | ||
| from io_scene_niftools.modules.nif_export.block_registry import block_store | ||
| from io_scene_niftools.utils import math | ||
| from io_scene_niftools.utils import math, consts | ||
|
|
||
|
|
||
| class Armature: | ||
|
|
@@ -83,6 +83,9 @@ def export_bone(self, b_obj, b_bone, n_parent_node, n_root_node): | |
| for b_child in b_bone.children: | ||
| self.export_bone(b_obj, b_child, n_node, n_root_node) | ||
|
|
||
| if b_bone.niftools.lag_bone.enabled: | ||
| self.export_lag_bone(b_bone, n_node) | ||
|
|
||
| def export_bone_flags(self, b_bone, n_node): | ||
| """Exports or sets the flags according to the custom data in b_bone or the game version if none was set""" | ||
| if b_bone.niftools.flags != 0: | ||
|
|
@@ -110,4 +113,26 @@ def export_bone_flags(self, b_bone, n_node): | |
| # default for Div 2 final bones | ||
| n_node.flags = 0x0196 | ||
| else: | ||
| n_node.flags = 0x0002 # default for Morrowind bones | ||
| n_node.flags = 0x0002 # default for Morrowind bones | ||
|
|
||
| def export_lag_bone(self, b_bone, n_node): | ||
| """Exports a BSLagBoneController for the bone""" | ||
|
|
||
| #BSLagBoneControllers are only for skyrim and later, afaik | ||
| game = bpy.context.scene.niftools_scene.game | ||
| if game not in ('SKYRIM'): | ||
| return | ||
|
|
||
| n_controller = block_store.create_block("BSLagBoneController") | ||
| n_controller.name = block_store.get_full_name(b_bone) | ||
| #This should be active and cycle, what I've seen in game. | ||
| n_controller.flags = b_bone.niftools.lag_bone.flags #0x0048? hexa? | ||
| n_controller.frequency = 1.0 | ||
| n_controller.phase = 0.0 | ||
| n_controller.start_time = consts.FLOAT_MIN | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are you sure these two aren't reversed? Both in the xml and the (admittedly single) BSLagBoneController I checked start_time is FLOAT_MAX and stop_time is FLOAT_MIN. |
||
| n_controller.stop_time = consts.FLOAT_MAX | ||
| n_controller.linear_velocity = b_bone.niftools.lag_bone.linear_velocity | ||
| n_controller.linear_rotation = b_bone.niftools.lag_bone.linear_rotation | ||
| n_controller.maximum_distance = b_bone.niftools.lag_bone.maximum_distance | ||
| #add controller to _this_ block | ||
| n_node.add_controller(n_controller) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could now be changed to
if not bpy.context.scene.niftools_scene.is_skyrim():