Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added RatioOfSums analyzer and tests #1

Closed
wants to merge 8 commits into from
Closed

Added RatioOfSums analyzer and tests #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
525af31
Added RatioOfSums analyzer and tests
scott-gunn Mar 26, 2024
7bf0eeb
Unit test for divide by zero and code cleanup.
scott-gunn Apr 1, 2024
c18e349
More detailed Scaladoc
scott-gunn Apr 1, 2024
f76ce89
Fixed docs to include Double.NegativeInfinity
scott-gunn Apr 1, 2024
39b0fac
Add copyright to new file
scott-gunn Apr 10, 2024
2334c5a
Fix bug when multiple values are returned.
scott-gunn Jun 24, 2024
17bb93b
Move ratio of sums test to their own section
scott-gunn Jun 24, 2024
624d248
Merge branch 'master' into feature/ratio_of_sums
scott-gunn Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/main/scala/com/amazon/deequ/analyzers/RatioOfSums.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,11 @@ case class RatioOfSums(
result: Row,
offset: Int
): Option[RatioOfSumsState] = {
if (result.isNullAt(offset)) {
None
} else {
Some(
ifNoNullsIn(result, offset, howMany = 2) { _ =>
RatioOfSumsState(
result.getDouble(0),
result.getDouble(1)
result.getDouble(offset),
result.getDouble(offset + 1)
)
)
}
}

Expand Down
7 changes: 5 additions & 2 deletions src/test/scala/com/amazon/deequ/analyzers/AnalyzerTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,7 +848,10 @@ class AnalyzerTests extends AnyWordSpec with Matchers with SparkContextSpec with
assert(analyzer.calculate(df).fullColumn.isDefined)
}

"compute ratio of sums correctly for numeric data" in withSparkSession { sparkSession =>
}

"Ratio of sums" should {
"compute ratio of sums correctly for numeric data" in withSparkSession { sparkSession =>
val df = getDfWithNumericValues(sparkSession)
RatioOfSums("att1", "att2").calculate(df).value shouldBe Success(21.0 / 18.0)
}
Expand All @@ -858,7 +861,7 @@ class AnalyzerTests extends AnyWordSpec with Matchers with SparkContextSpec with
assert(RatioOfSums("att1", "att2").calculate(df).value.isFailure)
}

"divide by zero" in withSparkSession { sparkSession =>
"fail if divide by zero" in withSparkSession { sparkSession =>
val df = getDfWithNumericValues(sparkSession)
val testVal = RatioOfSums("att1", "att2", Some("item IN ('1', '2')")).calculate(df)
assert(testVal.value.isSuccess)
Expand Down