Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access files in zip #18

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jarondl
Copy link

@jarondl jarondl commented Sep 1, 2013

This major commit keeps the files compressed in the zip archive,
accessing them on the fly. For that an independent library called
zipfileprovider was created. (It is also hosted on a different github repo).

Yaron de Leeuw added 4 commits September 1, 2013 15:14
This major commit keeps the files compressed in the zip archive,
accessing them on the fly. For that an independent library called
zipfileprovider was created. (It is also hosted on a different github repo).
git-subtree-dir: libs/zipfileprovider
git-subtree-split: 13f2c293f64cff630e9bba9d4acfb86bcfcec5d9
@jarondl
Copy link
Author

jarondl commented Sep 1, 2013

The first commit changes code in OxygenGuide,
the next three are less interesting and they regard the zipfileprovider subproject.

@nicolas-raoul
Copy link
Owner

Great!
I can't wait to test this :-)
I guess this results in serious SD card space savings.

@jarondl
Copy link
Author

jarondl commented Sep 1, 2013

Hi.
Yeah, we are down from about 1Gb to the size of the zip, which is about 100mb.
I want to add several clarifications.

  • The idea is based on this relatively new google play feature: http://developer.android.com/google/play/expansion-files.html
    but I think it should not be implemented as a whole, as it makes the app dependent on the google play store.
  • I have used their lib together with my own extension, which allows reading of compressed files.
  • I have changed the main java file to use this. It has also simplified the download process.
  • Currently it only works for htmlview, I have no idea how to make it work with an external browser.
  • I see that the version here is called 1.3, and on google play and f-droid it is 1.5. Were there many changes?
  • This is almost the first time I edit an android program, so I hope I havn't messed up all the sdk targets etc in the AndroidManifest, or anything else for that matter.

Its great that you are interested, and I hope the code will pass your testing

@nicolas-raoul
Copy link
Owner

I totally agree with you on the fact that we should not be dependent on Google Play, because it is not present on Android platforms like Kindle and most smartphones in China. Additionally, an app that relies on a proprietary library can not be called Open Source.

Indeed, we loose the ability to open in an external browser, but I guess it is unavoidable. The gain in size is worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants