Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for raw string literals #58

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dkearns
Copy link
Collaborator

@dkearns dkearns commented May 31, 2022

This is incomplete but probably does a decent job highlighting correct code.

TODO:

  • Single-line and multi-line raw strings should be handled separately and more strictly.
  • Invalid delimiter sequences should be highlighted as errors.
  • Normal strings shouldn't obscure errors by matching in invalid raw string literal syntax.
  • Should raw strings be coloured distinctly?

@nickspoons
Copy link
Owner

Thanks @dkearns. To answer your question, in my opinion no, raw strings shouldn't be highlighted differently to other strings. Despite the new semantics they are just strings at the end of the day, and people have expectations of those basic highlight colours. People who want them coloured differently can always link csRawString to something else in their personal config if they choose.

@dkearns dkearns mentioned this pull request Oct 14, 2022
16 tasks
@dkearns dkearns force-pushed the highlight-raw-string-literals branch from 467724f to ad374a3 Compare November 15, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants