Changed response decoding to the correct struct. closes #2

nickrobison · Mar 11, 2018 · 8335088 · 8335088
1 parent 23b0e61
commit 8335088
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/cloudflare.go b/cloudflare.go
@@ -123,7 +123,7 @@ func (c *cloudflareManager) updateDNSRecord(record cloudflareDNSRecord, ipAddres
 		logger.Fatalln(err)
 	}
 	defer dnsResponse.Body.Close()
-	var updatedRecord cloudflareDNSResponse
+	var updatedRecord cloudflareDNSUpdateResponse
 	err = json.NewDecoder(dnsResponse.Body).Decode(&updatedRecord)
 	if err != nil {
 		logger.Fatalln(err)

diff --git a/main.go b/main.go
@@ -100,15 +100,15 @@ func handleInterrupt(signalChannel chan os.Signal, cfm *cloudflareManager) {
 func updateCloudflareRecord(cfm *cloudflareManager) {
 
 	// Get an updated record
-	updatedIpAddress, err := getCurrentIPAddress(cfm.Client)
+	updatedIPAddress, err := getCurrentIPAddress(cfm.Client)
 	if err != nil {
 		logger.Println(err)
 		return
 	}
 
-	if updatedIpAddress != cfm.CurrentIPAddress {
-		logger.Printf("IP Address changed from %v, to %v\n", cfm.CurrentIPAddress, updatedIpAddress)
-		cfm.CurrentIPAddress = updatedIpAddress
+	if updatedIPAddress != cfm.CurrentIPAddress {
+		logger.Printf("IP Address changed from %v, to %v\n", cfm.CurrentIPAddress, updatedIPAddress)
+		cfm.CurrentIPAddress = updatedIPAddress
 
 		//	Get the cloudflare DNS records
 		records, err := cfm.GetDNSRecords()

diff --git a/structs.go b/structs.go
@@ -100,7 +100,7 @@ type cloudflareDNSResponse struct {
 
 type cloudflareDNSUpdateResponse struct {
 	cloudflareResponse
-	Result map[string]interface{}
+	Result cloudflareDNSRecord
 }
 
 type newCloudflareDNSRecord struct {