Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement nidcpower API parity with NI-DCPower 2023 Q1. #1907

Merged
merged 10 commits into from
Apr 11, 2023

Conversation

ni-jfitzger
Copy link
Collaborator

@ni-jfitzger ni-jfitzger commented Apr 5, 2023

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Adds entrypoints for NI-DCPower 22.8, 23.0 driver runtime
  • Adds tests for new methods
    • Unfortunately, the test has to be skipped. See the testing section.

List issues fixed by this Pull Request below, if any.

What testing has been done?

Manually tested with NI-DCPower 23.0 driver runtime and ni-grpc-device-server 23.0.

@ni-jfitzger ni-jfitzger changed the title Add nidcpower 22.8, 23.0 entrypoints Implement nidcpower API parity with NI-DCPower 2023 Q1. Apr 5, 2023
@ni-jfitzger
Copy link
Collaborator Author

With NI-DCPower 23.3 driver runtime, test_lcr_custom_cable_compensation_data is failing on the first call to configure_lcr_custom_cable_compensation with nidcpower.errors.DriverError: -1074118449: The provided compensation data is invalid. Provide a valid buffer or call niDCPower_GetLCRCompensationData to retrieve a valid set of cable compensation data..

I've tried inserting

        session.cable_length = nidcpower.CableLength.CUSTOM_AS_CONFIGURED
        session.perform_lcr_open_custom_cable_compensation()

at the beginning of the test, but it changed nothing.

@ni-jfitzger ni-jfitzger marked this pull request as ready for review April 5, 2023 21:28
@ni-jfitzger
Copy link
Collaborator Author

Even once the tests are fixed, this PR should wait until nimibot is updated to use the NI-DCPower 23.0 driver runtime or later.

@ni-jfitzger ni-jfitzger merged commit 539276f into ni:master Apr 11, 2023
@ni-jfitzger ni-jfitzger deleted the add-nidcpower-22.8-23.0-entrypoints branch April 11, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove nidcpower functions_addon.py override
2 participants