-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement nidcpower API parity with NI-DCPower 2023 Q1. #1907
Implement nidcpower API parity with NI-DCPower 2023 Q1. #1907
Conversation
- Override new functions to disable for GrpcStubInterpreter - Remove now redudant SetRuntimeEnvironment override
With NI-DCPower 23.3 driver runtime, test_lcr_custom_cable_compensation_data is failing on the first call to I've tried inserting
at the beginning of the test, but it changed nothing. |
Even once the tests are fixed, this PR should wait until nimibot is updated to use the NI-DCPower 23.0 driver runtime or later. |
…nto add-nidcpower-22.8-23.0-entrypoints
…nto add-nidcpower-22.8-23.0-entrypoints
What does this Pull Request accomplish?
List issues fixed by this Pull Request below, if any.
What testing has been done?
Manually tested with NI-DCPower 23.0 driver runtime and ni-grpc-device-server 23.0.
test_lcr_compensation_data
fails when run so we are skipping ittest_lcr_custom_cable_compensation_data
,test_lcr_compensation_data
should be re-enabled to run NI-DCPower 23.5 driver runtime #1908test_lcr_custom_cable_compensation_data apart
from 3 differencesget_lcr_compensation_data
is called instead ofget_lcr_custom_cable_compensation_data
configure_lcr_compensation
is called instead ofconfigure_lcr_custom_cable_compensation
session.configure_lcr_compensation(compensation_data.decode())
test_lcr_custom_cable_compensation_data
now fails.