Users/inkurdid/fix cert error #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dharaniprakashkm
requested review from
zhindes,
maxxboehme and
bkeryan
as code owners
|
@WayneDroid - I added you as a reviewer since you're handling the 1.0 release. Please give this an approval when you're accepting changes for post-1.0. FYI @bkeryan |
zhindes
approved these changes
Jul 7, 2024
WayneDroid
approved these changes
Jul 8, 2024
|
@dharaniprakashkm In future PRs on GitHub, please edit the PR title so it's not the same as your dev branch name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
SSL: CERTIFICATE_VERIFY_FAILED occurs when executing installdriver subcommand
Why should this Pull Request be merged?
Replaced urllib.requests with requests
fix #606
What testing has been done?
Tested the implementation on Windows 11 OS.