-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parameter rosette_meas_types type in docstrings #511
Fix parameter rosette_meas_types type in docstrings #511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is either a gap in our support for arrays of enumerations or some sort of issue with this specific function definition in the metadata. I want to say we have array of enums somewhere else in the API, so I think maybe the metadata is bad?
My point here is I don't think just no longer code-generating rosette is correct. I think there is a metadata problem. |
I think
It has a special case for enum arrays, so yeah, I think the metadata for this parameter is wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with suggestions (revert or delete private method's docstring)
Sorry, the review was in pending for a couple days because I forgot to submit it.
abc47bc
to
fa31caa
Compare
What does this Pull Request accomplish?
Added
'python_codegen_method': 'CustomCode'
toCreateAIRosetteStrainGageChan
in order to update parameterrosette_meas_types
type in the function.Why should this Pull Request be merged?
This PR is to address issue #483.
What testing has been done?