Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS template and DCO signoff #8

Merged
merged 5 commits into from
Jul 27, 2023

Conversation

jfriedri-ni
Copy link
Contributor

What does this Pull Request accomplish?

This PR updates NI's GitHub repo template to match the instructions in https://github.com/ni/.github/blob/main/profile/CONTRIBUTING.md

Why should this Pull Request be merged?

The repo template needs to match NI's open source policies.

What testing has been done?

None

jfriedri-ni and others added 4 commits July 10, 2023 10:17
@benmont
Copy link
Contributor

benmont commented Jul 24, 2023

@mbr0wn any concerns?

Copy link
Collaborator

@mbr0wn mbr0wn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on DCO checkbox.

@jfriedri-ni
Copy link
Contributor Author

@benmont -- I do not have privileges to merge. Please complete this PR when you are able.

@benmont benmont merged commit 004d82a into ni:main Jul 27, 2023
@jfriedri-ni jfriedri-ni deleted the add-code-owners-todo branch July 27, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants