Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove link to example of reversed button #2095

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Remove link to example of reversed button #2095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8fb8d2b
Remove link to example of reversed button
frankieroberto Nov 25, 2024
f8c518c
update changelog
anandamaryon1 Jan 20, 2025
6445dc5
Merge branch 'release-740' into remove-reversed-button-example-link
anandamaryon1 Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Unreleased

:wrench: **Maintenance**
- Removed an outdated link on the button component page
- Update example code in image component
- Remove same-page profession links from accessibility section

Expand Down
2 changes: 1 addition & 1 deletion app/views/design-system/components/buttons/index.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
}) }}

<h3>When to use a white button on solid background colour</h3>
<p>White buttons on solid background colour are good on components like interruption cards where link text, primary and secondary buttons would be lost. (There's an example on <a href="https://your-data-matters.service.nhs.uk/">the Your data matters service</a>.)</p>
<p>White buttons on solid background colour are good on components like interruption cards where link text, primary and secondary buttons would be lost.</p>
<p><a href="#when-to-use-buttons">More about when to use and not use buttons.</a></p>

<h2 id="warning-button">Warning button</h2>
Expand Down