DS-1462 Upgrade Python to 3.12 #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackPlowman
force-pushed
the
task/DS-1462_Upgrade_Python_Version
branch
2 times, most recently
from
b732ea9
to
95ee939
Compare
JackPlowman
force-pushed
the
task/DS-1462_Upgrade_Python_Version
branch
2 times, most recently
from
3696d48
to
bb3d1fe
Compare
|
mabe13
force-pushed
the
task/DS-1462_Upgrade_Python_Version
branch
2 times, most recently
from
c257ee5
to
32bef47
Compare
|
mabe13
force-pushed
the
task/DS-1462_Upgrade_Python_Version
branch
from
34c711a
to
137f93a
Compare
|
Tomdango
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Happy with the changes to the tests. Only query is removing the update of the packages inside the container - however, I'm happy to allow it as we should be pulling the latest lambda image and not messing with it too much.
I'm also assuming it broke some things in the change from Amazon Linux 2 to Amazon Linux 2023.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Branch Pull Request
https://nhsd-jira.digital.nhs.uk/browse/DS-1462
Description of Changes
This PR upgrades Python to 3.12