Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PriceClass variable so that it is configurable (V2) #20

Closed
wants to merge 11 commits into from

Conversation

andylamp
Copy link
Contributor

Description

This PR adds a price_class variable so that the respective CDN optimization can be set within the scope of the CloudFront distribution being created. Currently this is not supported and its value is hardcoded to some regions (instead of all).

Additionally, it allows the configuration of the cache policy that the distribution will use as this is currently this is not supported.

This PR addresses these limitations and introduces no breaking changes.

Context

Allow users to adjust the following parameters,

  • Price class for their CloudFront distribution,
  • Cache Policy of the created distribution.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@andylamp
Copy link
Contributor Author

@Tomdango hope that resolves the history issued and this can merged as expected.

@Tomdango
Copy link
Collaborator

@andylamp Included the changes in #21 as GitHub still wasn't resolving the Git history properly.
Also - one of the requirements of the repository is to have signed commits. Could you setup a GPG key in GitHub and sign your commits into this repository please?

@Tomdango Tomdango closed this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants