Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor shell scripts #137

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Refactor shell scripts #137

merged 5 commits into from
Oct 12, 2023

Conversation

stefaniuk
Copy link
Contributor

@stefaniuk stefaniuk commented Oct 6, 2023

Description

This is the first part of the refactoring effort to ensure that the shell scripts:

  • Follow a consistent convention,
  • Pass the ShellCheck linting test (please run make shellscript-lint-all), and
  • Work either with the pre-installed CLI tooling or run commands using Docker containers.

Context

Information for a reviewer:

  • The first two commits, a4517db and 7b94f14, implement stylistic and linting recommendations.
  • The last two commits, f8b9e84 and 22f7700, refactor how tools like Gitleaks and SonarScanner are executed.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@stefaniuk stefaniuk changed the title WIP: Refactor shell scripts Refactor shell scripts Oct 10, 2023
@stefaniuk stefaniuk marked this pull request as ready for review October 10, 2023 07:36
Copy link
Contributor

@regularfry regularfry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One slight clarification to a comment, otherwise this looks fine. "Please" isn't usually followed by a comma, and I thought it worth pointing out the details of what it is that we're asking people not to change.

.github/actions/scan-secrets/action.yaml Outdated Show resolved Hide resolved
scripts/githooks/check-file-format.sh Show resolved Hide resolved
scripts/githooks/check-file-format.sh Show resolved Hide resolved
@stefaniuk stefaniuk requested a review from regularfry October 12, 2023 10:46
@stefaniuk stefaniuk added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit 15499cb Oct 12, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants