Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve make config behaviour #133

Merged
merged 9 commits into from
Oct 4, 2023
Merged

Conversation

stefaniuk
Copy link
Contributor

@stefaniuk stefaniuk commented Sep 27, 2023

Description

  • This change fixes the unexpected behaviour of the make config command which fails when the asdf tool isn't correctly set up
  • asdf is no longer installed as part of the repository template, however it is listed as a required dependency
  • A fix to the check-file-format git pre-commit hook is also included as part of this PR

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

scripts/init.mk Outdated Show resolved Hide resolved
scripts/init.mk Outdated Show resolved Hide resolved
scripts/init.mk Outdated Show resolved Hide resolved
@stefaniuk stefaniuk changed the title Improve make config behaviour WIP: Improve make config behaviour Oct 3, 2023
@stefaniuk stefaniuk marked this pull request as draft October 3, 2023 13:48
@stefaniuk stefaniuk changed the title WIP: Improve make config behaviour Improve make config behaviour Oct 3, 2023
@stefaniuk stefaniuk marked this pull request as ready for review October 3, 2023 14:37
README.md Outdated Show resolved Hide resolved
@stefaniuk stefaniuk requested a review from regularfry October 4, 2023 07:24
Copy link
Contributor

@timireland timireland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@stefaniuk stefaniuk added this pull request to the merge queue Oct 4, 2023
Merged via the queue into main with commit 5f28100 Oct 4, 2023
22 checks passed
@stefaniuk stefaniuk deleted the Improve_make_config_behaviour branch October 4, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants