Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Example Tests on Pull Request #21

Closed
wants to merge 11 commits into from

Conversation

davethepunkyone
Copy link
Collaborator

@davethepunkyone davethepunkyone commented Oct 17, 2024

Description

This runs the example tests using GitHub actions on a pull request.

Context

It allows us to test our code is working before merging changes.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@davethepunkyone davethepunkyone self-assigned this Oct 17, 2024
@davethepunkyone davethepunkyone added configuration process github_actions Pull requests that update GitHub Actions code docker Pull requests that update Docker code labels Oct 17, 2024
@davethepunkyone davethepunkyone added this to the Initial POC Blueprint milestone Oct 17, 2024
@davethepunkyone
Copy link
Collaborator Author

Still WIP - the step in actions is passing but it should be failing currently due to the test change, and it's not outputting any logs. It's seeing the entrypoint now which should run pytest so unsure why it's not executing as expected but obviously needs some rework.

@davethepunkyone davethepunkyone removed the docker Pull requests that update Docker code label Oct 18, 2024
@davethepunkyone davethepunkyone changed the title Build Docker Container And Test Run Example Tests on Pull Request Oct 18, 2024
@davethepunkyone davethepunkyone deleted the add-docker-build-to-actions branch October 18, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration github_actions Pull requests that update GitHub Actions code process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant