Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move catch-all route-not-found handler to root #440

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Conversation

dbarrosop
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Nov 13, 2023

🦋 Changeset detected

Latest commit: 5305829

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hasura-auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dbarrosop dbarrosop changed the title fix: mount healthz endpoint before router to avoid overlapping issues fix: move catch-all route-not-found handler to root Nov 13, 2023
Copy link
Member

@onehassan onehassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can we include a changeset?

@dbarrosop dbarrosop merged commit ffba7d8 into main Nov 13, 2023
4 checks passed
@dbarrosop dbarrosop deleted the mounthhealthz branch November 13, 2023 15:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants