Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): update GitHub workflow to push to Docker Hub with git tag #432

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

onehassan
Copy link
Member

Checklist

  • No breaking changes
  • Tests pass

Copy link

changeset-bot bot commented Nov 6, 2023

⚠️ No Changeset found

Latest commit: 83c4f4a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@onehassan onehassan self-assigned this Nov 6, 2023
@dbarrosop
Copy link
Member

will this also push to ECR?

@onehassan
Copy link
Member Author

will this also push to ECR?

Yes it should be, the steps are there. I think it does but not using the correct version number. We will see upon the next release.

@onehassan onehassan merged commit c3fcb7f into main Nov 7, 2023
4 checks passed
@onehassan onehassan deleted the fix/ci/docker-git-tag branch November 7, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants