Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set oauth origin dynamically based on host header #427

Merged
merged 7 commits into from
Nov 8, 2023
Merged

Conversation

dbarrosop
Copy link
Member

@dbarrosop dbarrosop commented Nov 3, 2023

Solves #426

Copy link

changeset-bot bot commented Nov 3, 2023

🦋 Changeset detected

Latest commit: 8b86519

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hasura-auth Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

src/routes/oauth/index.ts Fixed Show fixed Hide fixed
src/routes/oauth/index.ts Fixed Show fixed Hide fixed
src/routes/oauth/utils.ts Show resolved Hide resolved
src/routes/oauth/index.ts Outdated Show resolved Hide resolved
src/app.ts Outdated Show resolved Hide resolved
@dbarrosop dbarrosop changed the base branch from main to prefix November 7, 2023 08:36
@dbarrosop dbarrosop marked this pull request as ready for review November 7, 2023 08:40
Copy link
Member

@onehassan onehassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@onehassan
Copy link
Member

Can you add a changeset as well

Base automatically changed from prefix to main November 7, 2023 10:40
@dbarrosop dbarrosop merged commit 024258c into main Nov 8, 2023
4 checks passed
@dbarrosop dbarrosop deleted the serverurl branch November 8, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants