Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(hasura-auth) keep select and delete permissions already set in metadata for auth tables instead of overriding them #407

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

juicygoose
Copy link
Contributor

@juicygoose juicygoose commented Jul 11, 2023

The documentation already mentions that it is possible to set permissions on auth tables.

Fixes #406

@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2023

🦋 Changeset detected

Latest commit: 5c7f3b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hasura-auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@onehassan onehassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reporting this and taking the time to fix this 🚀

src/utils/hasura-metadata/helpers.ts Outdated Show resolved Hide resolved
src/utils/hasura-metadata/helpers.ts Outdated Show resolved Hide resolved
@onehassan
Copy link
Member

onehassan commented Jul 11, 2023

@juicygoose it would be great also if you could add a changeset as mentioned here

… metadata for auth tables instead of overriding them
@juicygoose
Copy link
Contributor Author

juicygoose commented Jul 12, 2023

@juicygoose it would be great also if you could add a changeset as mentioned here

@onehassan Would it be possible for you to do it ? I have crashed linked to pnpm and node versions when trying to do it...

@onehassan onehassan merged commit ca5010d into nhost:main Jul 12, 2023
1 check passed
@juicygoose juicygoose deleted the bugfix/406 branch July 12, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth_refresh_token permissions for new role are deleted at nhost up
2 participants