Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve check between #1975

Merged
merged 2 commits into from
Oct 27, 2023
Merged

feat: improve check between #1975

merged 2 commits into from
Oct 27, 2023

Conversation

jajugoguma
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

Added beforeCheckBetween event to prevent consecutive checkbox clicks with shift-click. If this is prevented, it will behave the same as normal click behavior(just check or uncheck).

grid.on('beforeCheckBetween`, (e) => e.stop());

and added rowKey of click row checkbox argument on checkBetween event. The rowKey is the RowKey of the currently clicked row, which is only useful if the click is with the mouse.


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

Copy link

@jwlee1108 jwlee1108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다.

  • beforeCheckBetween에서 ev.stop()을 하는 것과 별개로, 이전에 체크된 행을 uncheck 하는 예제를 전달해야 할 것 같아요.

@jajugoguma
Copy link
Contributor Author

리뷰 완료합니다.

  • beforeCheckBetween에서 ev.stop()을 하는 것과 별개로, 이전에 체크된 행을 uncheck 하는 예제를 전달해야 할 것 같아요.

이전에 체크된 행을 uncheck 하는 예제이 어떤 예제를 의미하는지 알 수 있을까요?

@jwlee1108
Copy link

@jajugoguma

음..첫 번째 행 체크하고, 쉬프트 클릭으로 5번째 행을 체크할 때 2~4는 체크가 안되고 5만 체크되는건 맞는데 1이 그대로 남아있어서요.

문의 주신쪽에서 체크를 라디오처럼 쓰길 원한다면 예제를 따로 제공해야할 것 같다는 이야기였습니다.

@jajugoguma
Copy link
Contributor Author

@jajugoguma

음..첫 번째 행 체크하고, 쉬프트 클릭으로 5번째 행을 체크할 때 2~4는 체크가 안되고 5만 체크되는건 맞는데 1이 그대로 남아있어서요.

문의 주신쪽에서 체크를 라디오처럼 쓰길 원한다면 예제를 따로 제공해야할 것 같다는 이야기였습니다.

아하 넵넵. 해당 건은 완료 안내에 예제 코드를 같이 전달하도록 하겠습니다!

@jajugoguma jajugoguma merged commit 772ad30 into master Oct 27, 2023
3 of 4 checks passed
@jajugoguma jajugoguma deleted the feat/improve-check-between branch October 27, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants