-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: custom header by passing html element #1955
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๋ฆฌ๋ทฐ ์๋ฃํฉ๋๋ค.
Dictionary, | ||
OptCellEditor, | ||
OptCellRenderer, | ||
OptColumn, | ||
OptColumnHeaderInfo, | ||
OptComplexColumnInfo, | ||
Dictionary, | ||
OptFilter, | ||
OptRowHeader, | ||
OptRowHeaderColumn, | ||
OptTree, | ||
} from '@t/options'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P5: grid์ eslint์๋ sort-imports ๊ท์น์ด ์๋๋ฐ import๊ฐ ํ์ผ๋ง๋ค ๋ณ๊ฒฝ๋์ด ์๋ค์. ๊ฐ์ธ ์ค์ ์ ์ด ๊ท์น์ด ์ ์ฉ๋์ด ์๋๊ฑด์ง ํ์ธ ๋ถํ๋๋ ค์.
์๋ sort-imports ๊ท์น์ด ์๋ค๋ณด๋ ๋ค๋ฅธ ํ์ผ๋ ์ ๋ถ import๊ฐ ์ ๋ ฌ๋์ด ์์ง ์์์ ํ์ธํ๋ ํ์ผ๋ง๋ค ์ ๋ถ ๋ณ๊ฒฝ์ฌํญ์ด ์๊ธธํ
๋ฐ, ์ฌ์ค ์ด๊ฑด PR๊ณผ ๋ฌด๊ดํ ๋ณ๊ฒฝ์ฌํญ์ด๋ผ์์. ๋ง์ฝ sort-imports๋ฅผ ์ ์ฉํ๋๊ฒ ์ข์ ๊ฒ ๊ฐ๋ค๋ฉด PR ์๋ก ๋ง๋ค์ด์ ํ๋ฒ์ ์ ๋ถ ๋ณ๊ฒฝํ๋๋ก ํ๋ฉด ์ข์ ๊ฒ ๊ฐ์ต๋๋ค.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intellij์ ์ค์ ๋์ด ์์ด์ ๋ณ๊ฒฝ๋์๋ ๋ณด๋ค์... ์ด๊ฑด ์ถํ์ ํ๋ฒ์ ๋ณ๊ฒฝํ๋๋ก ํ๊ฒ ์ต๋๋ค ใ ใ
Please check if the PR fulfills these requirements
fix #xxx[,#xxx]
, where "xxx" is the issue number)Description
To-Be
Thank you for your contribution to TOAST UI product. ๐ ๐ โจ