Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom header by passing html element #1955

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Conversation

jajugoguma
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

  • Added custom header functionality.
    • You can set a variety of HTML elements in the header, including images, icons, and more.

To-Be

image

Thank you for your contribution to TOAST UI product. ๐ŸŽ‰ ๐Ÿ˜˜ โœจ

Copy link

@jwlee1108 jwlee1108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฆฌ๋ทฐ ์™„๋ฃŒํ•ฉ๋‹ˆ๋‹ค.

packages/toast-ui.grid/src/view/headerCheckbox.tsx Outdated Show resolved Hide resolved
Comment on lines +2 to 12
Dictionary,
OptCellEditor,
OptCellRenderer,
OptColumn,
OptColumnHeaderInfo,
OptComplexColumnInfo,
Dictionary,
OptFilter,
OptRowHeader,
OptRowHeaderColumn,
OptTree,
} from '@t/options';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P5: grid์˜ eslint์—๋Š” sort-imports ๊ทœ์น™์ด ์—†๋Š”๋ฐ import๊ฐ€ ํŒŒ์ผ๋งˆ๋‹ค ๋ณ€๊ฒฝ๋˜์–ด ์žˆ๋„ค์š”. ๊ฐœ์ธ ์„ค์ •์— ์ด ๊ทœ์น™์ด ์ ์šฉ๋˜์–ด ์žˆ๋Š”๊ฑด์ง€ ํ™•์ธ ๋ถ€ํƒ๋“œ๋ ค์š”.
์›๋ž˜ sort-imports ๊ทœ์น™์ด ์—†๋‹ค๋ณด๋‹ˆ ๋‹ค๋ฅธ ํŒŒ์ผ๋„ ์ „๋ถ€ import๊ฐ€ ์ •๋ ฌ๋˜์–ด ์žˆ์ง€ ์•Š์•„์„œ ํ™•์ธํ•˜๋Š” ํŒŒ์ผ๋งˆ๋‹ค ์ „๋ถ€ ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์ƒ๊ธธํ…๋ฐ, ์‚ฌ์‹ค ์ด๊ฑด PR๊ณผ ๋ฌด๊ด€ํ•œ ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด๋ผ์„œ์š”. ๋งŒ์•ฝ sort-imports๋ฅผ ์ ์šฉํ•˜๋Š”๊ฒŒ ์ข‹์„ ๊ฒƒ ๊ฐ™๋‹ค๋ฉด PR ์ƒˆ๋กœ ๋งŒ๋“ค์–ด์„œ ํ•œ๋ฒˆ์— ์ „๋ถ€ ๋ณ€๊ฒฝํ•˜๋„๋ก ํ•˜๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intellij์— ์„ค์ •๋˜์–ด ์žˆ์–ด์„œ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜ ๋ณด๋„ค์š”... ์ด๊ฑด ์ถ”ํ›„์— ํ•œ๋ฒˆ์— ๋ณ€๊ฒฝํ•˜๋„๋ก ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค ใ…Žใ…Ž

@jajugoguma jajugoguma merged commit 98c2dcc into master Aug 28, 2023
3 of 4 checks passed
@jajugoguma jajugoguma deleted the feat/custom_header branch August 28, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants