Skip to content

Commit

Permalink
Skip tests that depend on behavior of external domains
Browse files Browse the repository at this point in the history
These tests should be fixed
(chromium#112); in the meantime
disable them so that `make test` passes.
  • Loading branch information
nharper committed Jun 29, 2023
1 parent 9e257cb commit 2debedf
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
4 changes: 4 additions & 0 deletions domain_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,10 @@ var preloadableDomainTests = []preloadableDomainTest{
}

func TestPreloadableDomainAndRemovableDomain(t *testing.T) {
// Skip this test because it is failing due to relying on behavior of an
// external domain: https://github.com/chromium/hstspreload/issues/112.
t.SkipNow()

skipIfShort(t)
t.Parallel()

Expand Down
16 changes: 16 additions & 0 deletions redirects_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,10 @@ func TestIndirectInsecureRedirect(t *testing.T) {
}

func TestExplicitPortFirstRedirect(t *testing.T) {
// Skip this test because it is failing due to relying on behavior of an
// external domain: https://github.com/chromium/hstspreload/issues/112.
t.SkipNow()

skipIfShort(t)
t.Parallel()

Expand All @@ -127,6 +131,10 @@ func TestExplicitPortFirstRedirect(t *testing.T) {
}

func TestHTTPUnavailable(t *testing.T) {
// Skip this test because it is failing due to relying on behavior of an
// external domain: https://github.com/chromium/hstspreload/issues/112.
t.SkipNow()

skipIfShort(t)
t.Parallel()

Expand Down Expand Up @@ -161,6 +169,10 @@ func TestHTTPUnavailable(t *testing.T) {
}

func TestHSTSOverHTTP(t *testing.T) {
// Skip this test because it is failing due to relying on behavior of an
// external domain: https://github.com/chromium/hstspreload/issues/112.
t.SkipNow()

skipIfShort(t)
t.Parallel()

Expand Down Expand Up @@ -285,6 +297,10 @@ var preloadableHTTPRedirectsTests = []preloadableHTTPRedirectsTest{
}

func TestPreloadableHTTPRedirects(t *testing.T) {
// Skip this test because it is failing due to relying on behavior of an
// external domain: https://github.com/chromium/hstspreload/issues/112.
t.SkipNow()

skipIfShort(t)
t.Parallel()

Expand Down

0 comments on commit 2debedf

Please sign in to comment.