Fix node.lastKey never being set #1427
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where the key and translated value are the same or translated value isn't available the node.lastKey is never set. This causes issue ngx-translate#1416 where the value for the node constantly set to the same string.
fix typo
CodeAndWeb
added a commit
to CodeAndWeb/ngx-translate
that referenced
this pull request
Sep 23, 2024
CodeAndWeb
added a commit
to CodeAndWeb/ngx-translate
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where the key and translated value are the same or translated value isn't available the node.lastKey is never set.
This causes issue #1416 where the value for the node constantly set to the same string.