Translate objects recursively when key points to object in translations #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns. (ngx-translate#946) The following now works... translations.json ```json { OBJECT: { TEST: 'this is a test {{key}}', ANOTHER_TEST: 'this is another test {{key}}' } } ``` any view ```html <ul> <li *ngFor="let translation of 'OBJECT' | translate: { key: 'value' }">{ translation }</li> </ul> ``` result ```html <ul> <li>this is a test value</li> <li>this is another test value</li> </ul> ``` previously the interpolation would fail, resulting in ```html <ul> <li>this is a test {{key}}</li> <li>this is another test {{key}}</li> </ul> ```
bolemeus
commented
Apr 8, 2022
| @@ -25,7 +25,7 @@ | |||
| "experimentalDecorators": true, | |||
| "moduleResolution": "node", | |||
| "importHelpers": true, | |||
| "target": "es2017", | |||
| "target": "es2019", | |||
There was a problem hiding this comment.
wasn't sure about this one. I'm sure the code can be tweaked to avoid using Object.fromEntries
|
Integrated in upcoming ngx-transalte 16 |
|
In your fork v16, please do not make people confused |
|
Fixed in @ngx-translate/core@16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #946
Motivation:
I want to be able to use the translate pipe in combination with the
*ngForkeyword in my angular componentsWith this Pull Request the following now works...
translations.json
{ OBJECT: { TEST: 'this is a test {{key}}', ANOTHER_TEST: 'this is another test {{key}}' } }any view
result
previously the interpolation would fail, resulting in