Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pipe): add option to pipe to accept an array of string (concatenation) #1263

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion projects/ngx-translate/core/src/lib/translate.pipe.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,15 @@ export class TranslatePipe implements PipeTransform, OnDestroy {
this.translate.get(key, interpolateParams).subscribe(onTranslation);
}

transform(query: string, ...args: any[]): any {
transform(query: string|string[], ...args: any[]): any {
if (!query || !query.length) {
return query;
}

if (Array.isArray(query)) {
return this.transformArray(query, args);
}

// if we ask another time for the same key, return the last value
if (equals(query, this.lastKey) && equals(args, this.lastParams)) {
return this.value;
Expand Down Expand Up @@ -110,6 +114,12 @@ export class TranslatePipe implements PipeTransform, OnDestroy {
return this.value;
}

transformArray(queries: string[], ...args: any[]): any {
return queries
.map( query => this.transform(query, args))
.join('');
}

/**
* Clean any existing subscription to change events
*/
Expand Down