Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update to latest angular and nx #308

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yharaskrik
Copy link

@yharaskrik yharaskrik commented Sep 25, 2023

Updates:

  1. Nx
  2. Angular
  3. NgRx
  4. Anything else that Nx updates automatically.
  5. Min Node version (16 is EOL soon and v17 won't even support it)

Sets the peer deps to ^15 || ^16 to get rid of warnings when installing this library (which does work for 16)

 >  NX   Report complete - copy this into the issue template

   Node   : 18.17.0
   OS     : darwin-arm64
   yarn   : 1.22.19
   
   nx                 : 16.9.0
   @nx/js             : 16.9.0
   @nx/jest           : 16.9.0
   @nx/linter         : 16.9.0
   @nx/workspace      : 16.9.0
   @nx/angular        : 16.9.0
   @nx/cypress        : 16.9.0
   @nx/devkit         : 16.9.0
   @nx/eslint-plugin  : 16.9.0
   @nrwl/tao          : 16.9.0
   @nx/webpack        : 16.9.0
   typescript         : 5.1.6
   ---------------------------------------
   Community plugins:
   @ngrx/component-store : 16.2.0
   @ngrx/eslint-plugin   : 16.0.1
   @ngrx/router-store    : 16.2.0
   @ngrx/store           : 16.2.0

✨  Done in 0.74s.

@@ -5,65 +5,67 @@
"postinstall": "node ./decorate-angular-cli.js",
"build": "nx run-many --target=build --all",
"ci": "yarn lint && yarn test && yarn build",
"lint": "nx workspace-lint && nx run-many --target=lint --all --max-warnings=0",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this command is no longer needed.

jest.preset.js Outdated Show resolved Hide resolved
"@angular/core": "^15.0.0",
"@angular/router": "^15.0.0",
"@ngrx/component-store": "^15.0.0",
"@angular/core": "^15.0.0 || ^16.0.0",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm it DOES work in 16, we have been using it for a while.

Copy link
Member

@LayZeeDK LayZeeDK Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have recently put the library into production in a big Angular 16 app with complex routing configurations and route state usage and I can also confirm this. However, Router Component Store will follow the versioning scheme recommended by Angular: One major version of Router Component Store for every major version of Angular (and NgRx Component Store).

@LayZeeDK
Copy link
Member

LayZeeDK commented Sep 26, 2023

Thank you for your contribution, @yharaskrik 🙇‍♂️

I'm glad that you found Router Component Store useful!

Currently, I'm writing hundreds of tests to cover a wide range of route configurations before releasing the first stable version which will be version 15.0.0. Following that, a major version of the library will be released for each major version of Angular (16.x, 17.x, ...) and NgRx Component Store.

Feel free to join the ngworkers Discord server and we can discuss the plans further. I'm considering whether any breaking changes are needed before/after the first stable version.

@yharaskrik
Copy link
Author

Thank you for your contribution, @yharaskrik 🙇‍♂️

I'm glad that you found Router Component Store useful!

Currently, I'm writing hundreds of tests to cover a wide range of route configurations before releasing the first stable version which will be version 15.0.0. Following that, a major version of the library will be released for each major version of Angular (16.x, 17.x, ...) and NgRx Component Store.

Feel free to join the ngworkers Discord server and we can discuss the plans further. I'm considering whether any breaking changes are needed before/after the first stable version.

Feel free to close this if you already have plans with all this moving forward then!

No worries on my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants