-
Notifications
You must be signed in to change notification settings - Fork 126
Magnova driver #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Magnova driver #1031
Conversation
Added GetActiveChannelCount() method to dertermine memordy depth according to active channels and digital probe. Added digital channels. Try and fix memory leak.
Added AWG rise and fall time.
Fixed trigger channel update.
Fixed vertical offset.
Added some triggers. Fixed single capture.
Fixed uart trigger source.
Added sanity check on analog data length.
Added missing srate value.
…ed by Batronix. Added workaround to get mdepth from srate and timebase when set to Auto/Afast.
|
@azonenberg this PR is ready for review if you can. |
|
Unfortunately the new version also shows the same issues on waveform reads :-( I could not see anything suspicious in the Wireshark trace pointing to significant issues / breaking tcpip connection or so. The scope simply doesn't respond to the data readout. Here both captures: Firmware version you can see back from the traces :-) OK, it's the latest greates 1.7.1 version... UsbTmc has some issues on Magnova like transmitting no zero length packets [Batronix looks into that right now], would not be surprised if the TcpIp part has also some issues. |
|
Thanks for the feedback @xyphro . |
|
Hi Fredzo, as I use the same machine to do long term stress tests of another embedded device ethernet stacks I doubt an issue, but never say never. Also control other instruments with tcpip quite fine from that PC. Let me try another windows machine tomorrow, testing is much cooler than believing, right? :-) From the wireshark logs it get's also visible that Magnova does simply not respond. Antivirus/firewall? Nope. I understand that doubt but can exclude that from the list of potential issues. Letme see with another machine and report out tomorrow. With direct lan connection. In terms of steps: Just select the scope, then press once the play button. Sometimes it works, sometimes it gets stuck for me. |
|
Not that it is also configiration related on magnova. Or e.g. caused by having a samba share open from it?. Let's see, will spend half an hour after a sleep. |
|
I would bet on the SMB share! I haven't activated it on my side. |
|
Short interim testing state: with another ethernet adapter and direct connection and without DHCP it works pretty well on the same PC. Will now investigate on samba share. That one will not work in that setup scenario. So will turn it off in the original failing scenario. |
|
WOW, my suspicion was right: Having an active Samba connection kills SCPI on Magnova :-/ The good news is, that this means what you did is working as good as it is supposed to be. Will write this Andre. |
|
Even though it is unrelated to your magnova driver... would be super cool if you could try out samba share too to get a second confirmation. |
Fixed typo.
Hi Andrew,
As discussed, this PR is for Batronix Magnova scope driver.
It's not yet ready to merge (I'll remove the [WIP] tag when it is): it's being beta tested by EEVblog forum members and Batronix team.
I'll have beta testers file their reports here.
I'll create a doc PR soon for the driver documentation.
Best,
Frederic.