Skip to content

Conversation

@S3Prototype
Copy link
Collaborator

@S3Prototype S3Prototype commented Oct 2, 2025

This PR likely doesn't fix all indentation issues in our yaml snippets, but it does clean up the worst of the worst

It also removes pnpm run fmt from package.json because we have no intended formatting logic yet, and I don't want anyone running those commands thinking we endorse whatever they'll do to the repo yet

Add some pretier stuff

Update .prettierrc.json

Update .prettierrc.json

Update .prettierrc.json
@sg-writer sg-writer requested a review from joelhans October 2, 2025 17:22
@S3Prototype S3Prototype requested a review from sg-writer October 2, 2025 17:29
@sg-writer sg-writer added kind/bug Something isn't working docs/content Changes to the written material in the docs labels Oct 2, 2025
@S3Prototype
Copy link
Collaborator Author

@sg-writer Ready for another look

Copy link
Contributor

@joelhans joelhans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few places where the indentation isn't quite right, or uses tabs instead of spaces. Overall this is a massively important fix, TY!

@S3Prototype
Copy link
Collaborator Author

@joelhans I did a blanket fix of all the examples in this PR using a tool to fix the indentation. I tested them in the web traffic policy editor but may have still had slip-ups.

Since I've made so many changes, I just resolved all your previous comments since I can't tell if they're relevant anymore. Hopefully you can check this out when you get some time, and I'll address any errors you find asap

Copy link
Contributor

@joelhans joelhans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's another conversation to have about standardizing how we indent/structure our YAML consistently across the docs, but the most important thing here is that I dropped these onto a cloud endpoint and they are all valid, i.e. they don't break, so this is a huge step in the right direction!

@S3Prototype S3Prototype enabled auto-merge (squash) October 23, 2025 17:34
@S3Prototype S3Prototype merged commit aa9139c into main Oct 23, 2025
2 checks passed
@S3Prototype S3Prototype deleted the fix-indentation branch October 23, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs/content Changes to the written material in the docs kind/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants