-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Fix egregious indentation issues #1620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add some pretier stuff Update .prettierrc.json Update .prettierrc.json Update .prettierrc.json
This reverts commit 4bbd6a2.
|
@sg-writer Ready for another look |
joelhans
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a few places where the indentation isn't quite right, or uses tabs instead of spaces. Overall this is a massively important fix, TY!
Co-authored-by: Joel Hans <[email protected]>
…into fix-indentation
|
@joelhans I did a blanket fix of all the examples in this PR using a tool to fix the indentation. I tested them in the web traffic policy editor but may have still had slip-ups. Since I've made so many changes, I just resolved all your previous comments since I can't tell if they're relevant anymore. Hopefully you can check this out when you get some time, and I'll address any errors you find asap |
joelhans
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's another conversation to have about standardizing how we indent/structure our YAML consistently across the docs, but the most important thing here is that I dropped these onto a cloud endpoint and they are all valid, i.e. they don't break, so this is a huge step in the right direction!
This PR likely doesn't fix all indentation issues in our yaml snippets, but it does clean up the worst of the worst
It also removes pnpm run fmt from package.json because we have no intended formatting logic yet, and I don't want anyone running those commands thinking we endorse whatever they'll do to the repo yet