Add a less confusing non-existent response for public resources

ngobjects · Feb 25, 2024 · b248775 · b248775
1 parent 765b1cf
commit b248775
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/ng-appserver/src/main/java/ng/appserver/NGApplication.java b/ng-appserver/src/main/java/ng/appserver/NGApplication.java
@@ -416,6 +416,14 @@ private NGResponse noHandlerResponse( final NGRequest request ) {
 		}
 
 		final Optional<byte[]> resourceBytes = resourceManager().bytesForPublicResourceNamed( resourcePath );
+
+		// FIXME: Shouldn't we allow the user to customize the response for a non-existent resource? // Hugi 2024-02-05
+		if( resourceBytes.isEmpty() ) {
+			final NGResponse errorResponse = new NGResponse( "public resource '" + resourcePath + "' does not exist", 404 );
+			errorResponse.setHeader( "content-type", "text/html" );
+			return errorResponse;
+		}
+
 		return NGResourceRequestHandler.responseForResource( resourceBytes, resourcePath );
 	}