Skip to content

Refactor code due to param name change #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

Refactor code due to param name change #282

merged 1 commit into from
Jun 23, 2025

Conversation

lamATnginx
Copy link
Collaborator

Proposed changes

Adjust banner partial due to renamed param banner to be nd-banner found here - nginx/documentation#732

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx self-assigned this Jun 23, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner June 23, 2025 15:17
@lamATnginx lamATnginx changed the title Banner: Refactor code due to param name change Refactor code due to param name change Jun 23, 2025
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-hugo-theme/282/

@lamATnginx lamATnginx merged commit 0a682c4 into main Jun 23, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

Assignees

@lamATnginx lamATnginx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lamATnginx @ADubhlaoich