Skip to content

Killing Oldframe #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 76 commits into
base: main
Choose a base branch
from
Open

Killing Oldframe #276

wants to merge 76 commits into from

Conversation

lamATnginx
Copy link
Collaborator

Proposed changes

Lots of removing

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

Sorry, something went wrong.

nginx-jack and others added 3 commits June 9, 2025 14:37

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was signed with the committer’s verified signature.
nginx-jack Jack Hickey

Verified

This commit was signed with the committer’s verified signature.
@lamATnginx lamATnginx requested a review from a team as a code owner June 9, 2025 14:46
Copy link

github-actions bot commented Jun 9, 2025

Playwright visual snapshot differences were detected.

View the Playwright report
To approve the snapshot changes and update the snapshots, please comment: /approve-snapshots

Copy link

github-actions bot commented Jun 9, 2025

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-hugo-theme/276/

lamATnginx and others added 5 commits June 9, 2025 07:49

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
nginx-jack Jack Hickey

Verified

This commit was signed with the committer’s verified signature.
@nginx-jack
Copy link
Collaborator

Tab groups not working as expected - taking a look.

@lamATnginx
Copy link
Collaborator Author

lamATnginx commented Jun 12, 2025

F5 Sites button not working as expected as well. Related to the tabs group.

Edit: Resolved

Copy link

❌ One or more of the commit messages in this PR do not match the nginx-hugo-theme git guidelines, please check the CI job for more details on which commits were flagged and why.

Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

@lamATnginx lamATnginx force-pushed the mainframe branch 3 times, most recently from 0f6ac99 to 6de8fe8 Compare June 12, 2025 14:14

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
Copy link
Member

@TasoOneAsia TasoOneAsia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments around specifically tab group accessibility

lamATnginx and others added 2 commits June 17, 2025 10:03

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
TasoOneAsia Michael McKeen
lamATnginx and others added 30 commits July 3, 2025 10:17

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
nginx-jack Jack Hickey

Verified

This commit was signed with the committer’s verified signature.
nginx-jack Jack Hickey
A previous commit added a sidebar__content__wrapper which caused
the nested div, which previously handled scrolling, to no longer
function as expected. This moved the scrolling logic up to the wrapper
div instead.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Sidebar: Fix scroll

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Content: Remove next prev arrows

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Content: Replace with data attribute grid system

Add .content class to handle overall content reflow
Use scaling fonts
Refactor call outs to use grid utilities
TODO: Standard mobile sizes horz scroll on some pages
TODO: Homepage update to use grid utility
TODO: List card layout update to use grid utility

* Cards: Replace with data-grid

* Cards: Small tweaks

* Codeblock: Make highlighted lines stretch to end + fix border

* Homepage: Replace with data-grid and cards shortcode

* Scroll: Fixed issue with pages overflowing on mobile

* Breadcrumb: Cleaned up unused code with wide

* Fixed redocly responsive on new grid (#307)

* Redoc: Fixed responsive on new grid

* Redoc: Fix issue with redocly not going under header

* Codeblock: Extend highlight to left side

* Cards: Make cards fully clickable + small bug fix with grid ordering

* Add new 'card' page to example site + new tests for cards (#305)

* Cards: Replace with data-grid

* Cards: Add new page to example site

* Cards: Add tests

* Cards: Small tweaks

* Cards: Updated card params in example site

* Cards: Fix bugs with the card due to merge

* Grid: Resolved issue with grid on mobile

* Banner: Add spacing

* Card: Fixed relative pathing

---------

Co-authored-by: Lam Nguyen <[email protected]>
Co-authored-by: Lam <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Card: Fix issue with absolute url + icon path + reordered CSS

* Card: Revert first slash error

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Update reset to include `pre` tag for code block
Reduced "Last modified" section date
Remove horizontal rule from survey section

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Icon: Refactored to icon shortcode instead of fe + updated old icon code

* Icon: Fixed lucide partial

* Icon: Removed feather references

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Lam Nguyen <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Noticed that on hard page refreshes, and slower connections
that I would still see the extra vertical overflow caused by coveo.
I assumed it was a race condition, and wrapping the removal of
`atomic-relevance-inspector` in a timeout, would generally resolve it.
I didn't want a timeout to be the "fix" here, so I added the Mutation
Observer (https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver)
which appears to be the safest approach.
There's an overall 5 second timeout still, in case search never renders
for whatever reason.
Coveo: Fix vertical overflow race condition
* Spacing: Add margin variables throughout

Attempt to match figma spacing with headings
Add variables for ol and ul colours

* Spacing: Add callout and tab group spacing

* Icons: Fix icon usage in callouts

* Callout: Fix margin and whitespace in side callouts

* Typography: Wrap headers in .content class

Fix h1s on list pages not lining up with images

* Homepage: Fix card text overflow

* Content: Fix narrow content shifting between pages

* Layout: Fix outer container padding
Sidebar: Fix overflow missing some lines
…ages (#326)

* Redocly: Fix width issues

* Redoc: Fix auto scroll issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants