-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ip
as an option to listeners for VirtualServer
#6180
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
Pull requests for new features/feature enhancements
documentation
Pull requests/issues for documentation
go
Pull requests that update Go code
python
Pull requests that update Python code
labels
Aug 13, 2024
✅ Deploy Preview will be available once build job completes!
|
AlexFenlon
changed the title
[DRAFT] Add
Add Sep 5, 2024
ip
as an option to listeners for VirtualServer
ip
as an option to listeners for VirtualServer
j1m-ryan
reviewed
Sep 5, 2024
docs/content/configuration/global-configuration/globalconfiguration-resource.md
Outdated
Show resolved
Hide resolved
examples/custom-resources/custom-ip-listeners/virtualserver/README.md
Outdated
Show resolved
Hide resolved
examples/custom-resources/custom-ip-listeners/virtualserver/README.md
Outdated
Show resolved
Hide resolved
j1m-ryan
reviewed
Sep 5, 2024
j1m-ryan
reviewed
Sep 5, 2024
j1m-ryan
reviewed
Sep 5, 2024
Signed-off-by: Alex Fenlon <[email protected]>
j1m-ryan
approved these changes
Sep 5, 2024
jjngx
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Pull requests/issues for documentation
enhancement
Pull requests for new features/feature enhancements
go
Pull requests that update Go code
helm_chart
Pull requests that update the Helm Chart
python
Pull requests that update Python code
tests
Pull requests that update tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds the ability for NIC to listen a custom ipv4 or ipv6 ip address using custom listeners with Virtual Server and global configuration.
Resolves: #6067
Below is the output when IPV4 and IPV6 are in both http and https custom listeners
Virtual Server:
GlobalConfiguration:
nginx.conf snippet:
I set up a debug container using the below command to check if the pod is listening on the set ports and ips:
Checklist
Before creating a PR, run through this checklist and mark each as complete.