Provisional ProxySettingsPolicy proposal #4237
Conversation
github-actions
bot
added
the
documentation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4237 +/- ##
==========================================
+ Coverage 86.10% 86.11% +0.01%
==========================================
Files 131 131
Lines 14162 14162
Branches 35 35
==========================================
+ Hits 12194 12196 +2
+ Misses 1765 1764 -1
+ Partials 203 202 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| ## Goals | ||
|
|
||
| - Define proxy settings for buffering configuration. | ||
| - Define an API for proxy settings that is extensible to support additional proxy directives in the future. | ||
| - Outline the attachment points (Gateway and HTTPRoute/GRPCRoute) for the proxy settings policy. | ||
| - Describe the inheritance behavior of proxy settings when multiple policies exist at different levels. |
There was a problem hiding this comment.
Since the initial design and implementation is explicitly supporting proxy_buffer_size, proxy_buffers, proxy_buffering and proxy_busy_buffers_size, should we call that out in the goals?
I see the non-goals says "only buffering directives are in scope for initial implementation", which might cover the same point. I can see that being a point of confusion in the design review.
There was a problem hiding this comment.
I have in the first goal - Define proxy settings for buffering configuration. The specific directives feel like implementation details to me.
|
|
||
| ## Non-Goals | ||
|
|
||
| - Define the complete set of all proxy directives (only buffering directives are in scope for initial implementation). |
There was a problem hiding this comment.
I saw these directives don't get applied to stream blocks, so support for this will only be for GRPC and HTTRoutes right?
We should add info in non-goal about this
Proposed changes
Problem: As a user of NGF
I want a design to configure NGINX's proxy buffer configuration for my applications through the use of ProxySettingsPolicy
So that I can implement the ProxySettingsPolicy CRD
Solution: Create the provisional ProxySettingsPolicy enhancement proposal
Partially implements #4067
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.