Skip to content

Add additional validation to otel endpoint #7909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025

Conversation

javorszky
Copy link
Contributor

@javorszky javorszky commented Jun 17, 2025

Proposed changes

  • Add additional validation to otel endpoint to make sure URI is valid

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@javorszky javorszky requested a review from a team as a code owner June 17, 2025 12:31
@github-actions github-actions bot added enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code labels Jun 17, 2025
@javorszky javorszky force-pushed the feat/otel-endpoint-validation branch from 46c725c to 4d10050 Compare June 17, 2025 12:32
vepatel
vepatel previously approved these changes Jun 17, 2025
@vepatel vepatel dismissed their stale review June 17, 2025 12:40

failing Unit test

@vepatel vepatel self-requested a review June 17, 2025 12:40
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 91.89189% with 6 lines in your changes missing coverage. Please review.

Project coverage is 52.82%. Comparing base (71639ef) to head (e5afbc9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/validation/validation.go 91.30% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7909      +/-   ##
==========================================
+ Coverage   52.67%   52.82%   +0.15%     
==========================================
  Files          90       90              
  Lines       21598    21671      +73     
==========================================
+ Hits        11376    11447      +71     
- Misses       9745     9747       +2     
  Partials      477      477              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vepatel vepatel moved this from Todo ☑ to In Review 👀 in NGINX Ingress Controller Jun 17, 2025
@javorszky javorszky force-pushed the feat/otel-endpoint-validation branch from 380f4e6 to e5afbc9 Compare June 18, 2025 08:17
@javorszky javorszky merged commit 31e9d13 into main Jun 18, 2025
166 of 176 checks passed
@javorszky javorszky deleted the feat/otel-endpoint-validation branch June 18, 2025 10:54
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done 🚀 in NGINX Ingress Controller Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants