Add VersionCheck and Metadata to Agent labels #7737
Conversation
github-actions
bot
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7737 +/- ##
==========================================
- Coverage 52.35% 52.27% -0.08%
==========================================
Files 89 90 +1
Lines 21373 21478 +105
==========================================
+ Hits 11190 11228 +38
- Misses 9717 9780 +63
- Partials 466 470 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| return "", fmt.Errorf("replicaset %s has no owner", replicaSet.Name) | ||
| case "DaemonSet": | ||
| return owner.Name, nil | ||
| default: |
There was a problem hiding this comment.
Should we allow users to use StatefulSets?
There was a problem hiding this comment.
didn't know we supported this, yeah i'll put it in.
There was a problem hiding this comment.
I was just doing the same as here
https://github.com/nginx/kubernetes-ingress/pull/7737/files#diff-eff510a0b73d7f9c4a36caa7215b19fef8d460421c3026ae7f9e7bd827b8077aR61-R63
so will I update this too?
| return "", err | ||
| } | ||
| owners := pod.GetOwnerReferences() | ||
| if len(owners) != 1 { |
There was a problem hiding this comment.
Why might the pod only have one owner? The user can set this up how they want.
There was a problem hiding this comment.
similar to here
but yeah not sure why we had this like that...
Proposed changes
Checklist
Before creating a PR, run through this checklist and mark each as complete.